Skip to content

feat!: add ability to skip retry delay#103

Open
ns-vasilev wants to merge 1 commit intomainfrom
feature/retry
Open

feat!: add ability to skip retry delay#103
ns-vasilev wants to merge 1 commit intomainfrom
feature/retry

Conversation

@ns-vasilev
Copy link
Copy Markdown
Member

@ns-vasilev ns-vasilev commented May 5, 2026

No description provided.

@ns-vasilev ns-vasilev self-assigned this May 5, 2026
@ns-vasilev ns-vasilev requested a review from a team as a code owner May 5, 2026 14:36
@ns-vasilev ns-vasilev changed the title feat: add ability to skip retry delay feat!: add ability to skip retry delay May 5, 2026
@spacecode-github-bot
Copy link
Copy Markdown

spacecode-github-bot commented May 5, 2026 •
edited
Loading

3 Warnings
⚠️ PR title should follow Conventional Commits format (e.g., "feat: add new feature")
⚠️

⚠️ Some source files are missing corresponding test files:

  • RetryAction → expected test file: RetryActionTests.swift
⚠️ Public API changed but no documentation updates found

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.31%. Comparing base (1732c77) to head (45e29e1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Typhoon/Classes/Model/RetryAction.swift 0.00% 3 Missing ⚠️
...lasses/RetryPolicyService/RetryPolicyService.swift 91.30% 2 Missing ⚠️
...asses/RetryPolicyService/IRetryPolicyService.swift 0.00% 1 Missing ⚠️
...itTests/RetryService/RetryPolicyServiceTests.swift 96.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   98.60%   98.31%   -0.29%     
==========================================
  Files          27       28       +1     
  Lines        1854     1895      +41     
==========================================
+ Hits         1828     1863      +35     
- Misses         26       32       +6
Files with missing lines Coverage Δ
...on/Classes/Extensions/URLSession+RetryPolicy.swift 100.00% <ø> (ø)
...s/RetryService/RetryPolicyServiceLoggerTests.swift 100.00% <100.00%> (ø)
...rvice/RetryPolicyServiceRetryWithResultTests.swift 100.00% <100.00%> (ø)
...tTests/URLSession/URLSessionRetryPolicyTests.swift 97.86% <100.00%> (ø)
...asses/RetryPolicyService/IRetryPolicyService.swift 40.00% <0.00%> (ø)
...itTests/RetryService/RetryPolicyServiceTests.swift 99.74% <96.88%> (-0.26%) ⬇️
...lasses/RetryPolicyService/RetryPolicyService.swift 98.11% <91.30%> (-1.89%) ⬇️
Sources/Typhoon/Classes/Model/RetryAction.swift 0.00% <0.00%> (ø)

@ns-vasilev
feat: add ability to skip retry delay
45e29e1 
- Introduce `RetryAction` enum to specify post-failure behavior (.retry, .skipDelay, .stop).
- Update `IRetryPolicyService` and `RetryPolicyService` to use `RetryAction` in `onFailure` closures.
- Implement immediate retry logic when `.skipDelay` is returned.
- Maintain backward compatibility for boolean literals via `ExpressibleByBooleanLiteral`.
- Update `URLSession` extensions and unit tests to support the new API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ns-vasilev ns-vasilev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ns-vasilev @spacecode-github-bot